Node / mirrors / respira / commits / e44bea1

Parents : 851d37c

Author : Jan-Henrik Bruhn <jan-henrik.bruhn@offis.de>

Date : 2025-12-26T23:29:08+01:00

fix: Remove module-level side effect from useMachineStore initialization

**Problem:**

Store initialization was happening at module load via side effect:

```typescript

useMachineStore.getState()._setupSubscriptions();

```

This caused several issues:

- Executed before app was ready

- Made testing difficult (runs before test setup)

- Hard to control initialization timing

- Could cause issues in different environments

**Solution:**

- Added public `initialize()` method to useMachineStore

- Call initialization from App component's useEffect (proper lifecycle)

- Removed module-level side effect

**Benefits:**

- ✅ Controlled initialization timing

- ✅ Better testability (no side effects on import)

- ✅ Follows React lifecycle patterns

- ✅ No behavioral changes for end users

**Testing:**

- Build tested successfully

- Linter passed

- All TypeScript types validated

Fixes #38

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2 files changed, 14 insertions(+), 3 deletions(-)

M src/App.tsx +6

M src/stores/useMachineStore.ts +8 -3

--- a/src/App.tsx

+++ b/src/App.tsx

import { useEffect } from "react";

import { useShallow } from "zustand/react/shallow";

import { useMachineCacheStore } from "./stores/useMachineCacheStore";

import { usePatternStore } from "./stores/usePatternStore";

import { useUIStore } from "./stores/useUIStore";

document.title = `Respira v${__APP_VERSION__}`;

}, []);

// Machine cache store - for auto-loading cached pattern

const { resumedPattern, resumeFileName } = useMachineCacheStore(

useShallow((state) => ({

--- a/src/stores/useMachineStore.ts

+++ b/src/stores/useMachineStore.ts

resumeSewing: () => Promise<void>;

deletePattern: () => Promise<void>;

// Internal methods

_setupSubscriptions: () => void;

_startPolling: () => void;

}

},

// Setup service subscriptions

_setupSubscriptions: () => {

const { service } = get();

},

}));

// Selector hooks for common use cases

export const useIsConnected = () =>

useMachineStore((state) => state.isConnected);